Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ADF-1417/Upgrade to Node 18 #16

Merged
merged 6 commits into from
May 11, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions .Jenkinsfile

This file was deleted.

13 changes: 13 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# http://editorconfig.org
root = true

[*]
indent_style = space
indent_size = 4
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
trim_trailing_whitespace = false
8 changes: 8 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
version: 2
updates:
- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "daily"
ignore:
- dependency-name: "eslint*"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldt you have a line at the end of this file? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could indeed but this is not a blocker

53 changes: 53 additions & 0 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Continuous integration

on:
pull_request:
branches: [develop]

jobs:
code-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
token: ${{ secrets.GH_TOKEN }}
- run: git fetch --tags --unshallow
- name: Check commit
if: always()
uses: oat-sa/conventional-commit-action@v0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/setup-node@v1
with:
node-version: 18.x
registry-url: https://registry.npmjs.org
- name: Install packages
run: npm ci
env:
NODE_AUTH_TOKEN: ${{ secrets.BUILD_NPM_TOKEN }}
- name: Running tests
run: npm run test:cov
- name: Build coverage
run: npm run coverage:clover
- name: Report coverage
if: always()
uses: slavcodev/coverage-monitor-action@1.1.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
clover_file: coverage/clover.xml
threshold_alert: 75
threshold_warning: 90
comment_mode: update
- name: Save Code Linting Report JSON
if: always()
run: npm run lint:report | true
- name: Annotate Code Linting Results
if: always()
continue-on-error: true
uses: ataylorme/eslint-annotate-action@1.2.0
with:
repo-token: '${{ secrets.GITHUB_TOKEN }}'
report-json: 'eslint_report.json'
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ typings/

# Optional eslint cache
.eslintcache
eslint_report.json

# Optional REPL history
.node_repl_history
Expand All @@ -58,4 +59,4 @@ typings/
.env

# next.js build output
.next
.next
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* Copyright (c) 2019 (original work) Open Assessment Technologies SA ;
*/

const minimatch = require('minimatch');
const { minimatch } = require('minimatch');

module.exports = (externals = []) => ({
name: 'external-alias', // this name will show up in warnings and errors
Expand Down
Loading