Feature/ADF-1417/Upgrade to Node 18 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
rgomeztao
approved these changes
Apr 26, 2023
| @@ -45,7 +45,7 @@ const errorHandler = { | |||
| /** | |||
| * Get a context by it's name and create it if it doesn't exists | |||
| * @param {String} name - the context name | |||
| * @returns {Object} the handling context | |||
| * @returns {Object|undefined} the handling context | |||
| */ | |||
There was a problem hiding this comment.
i understand this task is just fixing the doc, so no issues, but wouldnt it be nice that this handler return null instead of undefined? :)
There was a problem hiding this comment.
Yes, actually it would be better to refactor the code in order to keep a consistent behavior.
But I did not want to change it, and only avoid adding lint error due to the version change
…F-1417/upgrade-to-node18
This was referenced Apr 26, 2023
shaveko
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
7 tasks
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: ADF-1417 and ADF-1419
Requires:
package.jsononce the companion PRs have been merged and releasedSummary
Update the devDependencies for supporting Node 18
Set Node 18 for the CI workflow.
Details
To properly support Node 18, the dev dependencies had to be updated and aligned.
Note: The lock file was generated with
npm@6so it would also work seamlessly with Node 14.How to test
npm inpm test,npm run test:cov,npm run coveragenpm run buildnpm run lint:src,npm run lint:test