Remove property chains inferring develops_from over part_of. #1808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes two property chains:
part_of o develops_from -> develops_from
develops_from o part_of -> develops_from
We noticed these causing some unexpected inferences in GO, for example
protein-containing complex
being inferred to develop from ananatomical entity
. These should be in RO anyway, if they were to be accepted.I also deleted these chains from the
cl_import.owl
. I looked at the CL source, and I think they got these via Uberon, so hopefully that bit of ontology autophagy will be cleaned up when both have releases.I computed a reasoned file using this command:
robot reason --catalog catalog-v001.xml --exclude-duplicate-axioms true --remove-redundant-subclass-axioms true -i uberon_edit.obo -o reasoned-new.ofn
and compared before and after the changes using
robot diff
. Somewhat unexpectedly, I didn't see any classification differences.