-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2022 03 31 (easier review) #2376
Conversation
removed anatomical entity doesn seem a big deal, as they have is_a axioms to something that is basically an anatomical entity, im guessing that this is because of the changes in bridge equivalence to caro - don't think its a huge deal |
Copying this over: Things I would like to get signed off/source found before committing to the release:
|
for the epithelium stuff, it might be this: 5a65039 in which case it should be fine, but its weird that it didnt show up in the logical diff? |
I'm looking at a few classes with 'structure with developmental contribution from neural crest' - and it seems that they can be inferred some other way, so it makes sense that those axioms are removed. The question I have is why is it happening this time? |
This is super weird! So many GCIs removed does not smell good. Can we somehow figure out which file they were supposed to be in? originally? (The GCIs cannot be in Uberon..). Is it possible they came back through some import in the past? |
oh that explains it, sorry lol, was using the edit file, should probably have used the built uberon >.< just checked all good |
left to do: see if epithelium stuff is also just removing things that can be inferred |
Potential reason for massive changes: obophenotype/cell-ontology#1532 |
These property chains were removed on purpose: #1808 |
strange that the changes are only showing up in this release? I'm guessing because of all the import dependencies, it took awhile to finally be clean? |
I agree, it sure took a while! But the imports have been a tangle. There are some axioms that only live in imports and get passed back and forth. |
@shawntanzk can you do the final review here and approve! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this!
For future reference, this is yet undadressed: #2382 |
No description provided.