Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zygote stage part of life cycle only in Metazoa. #2530

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Jun 14, 2022

Related to #2349. This fixes an issue with taxon constraints in GO for yeast annotations: geneontology/go-ontology#23012

@balhoff balhoff requested a review from cmungall June 14, 2022 13:37
@balhoff
Copy link
Member Author

balhoff commented Jun 14, 2022

Need to discuss before merging this; now I'm wondering if instead this other axiom should become a Metazoa-specific GCI:

'anatomical structure' SubClassOf 'existence ends during or before' some 'death stage'

I previously did that for:

'anatomical structure' and ('in taxon' some Metazoa) SubClassOf 'existence starts during or after' some 'zygote stage'

We need to decide exactly which Uberon terms are pan-life and which are metazoan. Is 'life cycle' general? Is 'anatomical structure' general?

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-06-14/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-06-14/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

life cycle http://purl.obolibrary.org/obo/UBERON_0000104

Removed

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

GCIs

Added

life cycle http://purl.obolibrary.org/obo/UBERON_0000104

Removed

@github-actions
Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

@cmungall
Copy link
Member

@balhoff I think we should go ahead and merge this. This PR is consistent with your sketch of what are the general terms in #2349

I'm actually not sure I am following your comment above. zygote is certainly more specific than the beginning of life. but to make start and end mirror each other maybe there should be a generic "coming into existence stage" with zygote stage a subclass?

In any case let's merge this and continue discussing details on the main issue

@balhoff balhoff merged commit 4fa1216 into master Aug 16, 2022
@balhoff balhoff deleted the zygote-stage-metazoa branch August 16, 2022 18:53
@shawntanzk shawntanzk mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants