Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a proposed update that changes inheres in to the characteristic of model #284

Closed
wants to merge 2 commits into from

Conversation

leechuck
Copy link

No description provided.

@zhengj2007
Copy link
Collaborator

This change intends to apply to quality only or apply to 'specifically dependent continuant' including 'realizable entity' like disposition and role.
Current "realized in" relation is used to associate 'realizable entity' with process. If we just relabel the RO: "inheres in" (RO:0000052) and changed the range to "independent continuant" or "process", does it mean RO: "realized in" (BFO_0000054) is a subProperty of RO: "characteristic of"? If not, what's difference between a 'realizable entity' 'realized in' a process and a 'realizable entity' 'characteristic of' a process?

@cmungall
Copy link
Contributor

This PR needs to be done against ro-edit rather than ro... I promised to do this but have not yet

@cmungall cmungall added the discussion For discussion on RO calls or at RO meeting label Feb 12, 2019
@alanruttenberg
Copy link

It's a bit hard to tell, but it looks like the changes have more than just this change. Could someone check?

@cmungall
Copy link
Contributor

cmungall commented Jun 3, 2019

There is an additional complication beyond just migrating the edits to the edit file.

TL;DR - characteristic-of can't be a super-property of a property representing what the current BFO2 reference calls inheres-in

For the phenotype work, the assumption was always that the relation linking the quality to the IC/process was functional. We set this out here:
http://webont.org/owled/2007/PapersPDF/paper_40.pdf

We didn't just make this up. It was entirely our understanding at that time (pre BFO formalization in a non-PDF form) that inheres-in was intended to be functional. See equation A7 in Fabian, Pierre, and Barry's paper, which we took to be canonical:
http://ontology.buffalo.edu/bfo/SQU.pdf
(the mapping to OWL maybe isn't quite so clear due to the use of n-ary relations for relational qualities)

(note that paper explicitly deferred on QoPs)

So if the URI we are using becomes the super-property of what is now what the BFO2 reference calls inheres-in, we cannot declare this to be functional with inducing the same characteristic on BFO2:inheres_in, which is not intentional according to the reference, due to the following definition that was introduced for relational qualities:
Definition: b is a relational quality = Def. for some independent continuants c, d and for some time t: b quality_of c at t & b quality_of d at t. [057-001]

If we want to declare RO_0000052 as functional, then this has to become a sibling of BFO2:inheres_in. This goes further than what we all agreed upon.

An alternate option is that BFO2 abandons its approach to RQs and adopts the one we use in PATO where inheres-in is used as a functional relation, and the additional relatum for a RQ gets a different object property (currently awkwardly called 'towards'). This is more in the spirit of the Neuhaus paper I think. (FWIW, I think the PATO community may be the only one using RQs, and they cause widespread confusion).

@bpeters42
Copy link
Collaborator

Discussed this on the call 6/4 which Chris M could unfortunately not join. Consensus that some solution needs to appear fast, and that Chris M needs to weigh in if what Alan is proposing above works for him.

@cmungall
Copy link
Contributor

cmungall commented Jul 30, 2019

Discussed on RO call today, all in agreement, see https://docs.google.com/document/d/19dhzj5QoliQZQgDJRczI878rLtexzMDo1g0K9_LRUWk/edit#

We will implement this structure (names not yet decided):

  • [new] characteristic of or inheres in [domain: SDC, range: Thing]
    • RO_0000052 functional characteristic of [properties: functional]
    • inheres_in [equivalent to inheres in in the bfo2 ref doc] [range: IC]

We will decide on labels shortly.

@phismith
Copy link

phismith commented Jul 30, 2019 via email

@alanruttenberg
Copy link

alanruttenberg commented Jul 30, 2019 via email

@alanruttenberg
Copy link

alanruttenberg commented Jul 30, 2019 via email

@alanruttenberg
Copy link

alanruttenberg commented Jul 31, 2019 via email

@bpeters42
Copy link
Collaborator

bpeters42 commented Jul 31, 2019 via email

@alanruttenberg
Copy link

alanruttenberg commented Jul 31, 2019 via email

@bpeters42
Copy link
Collaborator

bpeters42 commented Jul 31, 2019 via email

@alanruttenberg
Copy link

alanruttenberg commented Jul 31, 2019 via email

@cmungall cmungall self-requested a review July 31, 2019 19:34
@cmungall
Copy link
Contributor

cmungall commented Jul 31, 2019

@dosumis and @matentzn advocate for something like:

  • [new] ugly disjunctive name [domain: SDC, range: Thing]
    • RO_0000052 "characteristic of" [properties: functional]
    • inheres_in [equivalent to inheres in in the bfo2 ref doc] [range: IC]

Copy link
Contributor

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be merged - this PR is now serving as more of a ticket for a new PR. See other comments

@phismith
Copy link

phismith commented Aug 1, 2019 via email

@phismith
Copy link

phismith commented Aug 1, 2019 via email

@cmungall cmungall marked this pull request as draft March 18, 2021 17:45
@cmungall
Copy link
Contributor

new PR here: #442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion For discussion on RO calls or at RO meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants