Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support recursive enable_if in tests #6132

Closed
samoht opened this issue Sep 7, 2022 · 1 comment
Closed

support recursive enable_if in tests #6132

samoht opened this issue Sep 7, 2022 · 1 comment

Comments

@samoht
Copy link
Member

samoht commented Sep 7, 2022

Using an enabled_if library in a test stanza protected by an enabled_if is not supported while it is for tests.

For instance https://github.com/ocaml-multicore/eio/blob/6a85b668a7cf75efcd304cba0fadabc0e2866b03/lib_eio_linux/tests/dune#L25-L30

On macOS This will fail with:

❯ dune build
File "lib_eio_linux/tests/dune", line 30, characters 21-30:
30 |  (libraries alcotest eio_linux))
                          ^^^^^^^^^
Error: Library "eio_linux" in _build/default/lib_eio_linux is hidden
(unsatisfied 'enabled_if').
-> required by _build/default/lib_eio_linux/tests/test.bc
-> required by alias lib_eio_linux/tests/all
-> required by alias default

Changing the test into executable works.
voodoos added a commit to voodoos/dune that referenced this issue Sep 7, 2022
@voodoos
Add a test illustrating issue ocaml#6132
5037267 
When a test is disabled dune shouldn't check the availability of its
dependencies.
@voodoos voodoos mentioned this issue Sep 7, 2022
Closed
voodoos added a commit to voodoos/dune that referenced this issue Sep 7, 2022
@voodoos
Add a test illustrating issue ocaml#6132
1d793cb 
When a test is disabled dune shouldn't check the availability of its
dependencies.

Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
voodoos added a commit to voodoos/dune that referenced this issue Sep 8, 2022
@voodoos
Add a test illustrating issue ocaml#6132
6718143 
When a test is disabled dune shouldn't check the availability of its
dependencies.

Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
voodoos added a commit to voodoos/dune that referenced this issue Sep 8, 2022
@voodoos
Add a test illustrating issue ocaml#6132
227ca90 
When a test is disabled dune shouldn't check the availability of its
dependencies.

Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
@emillon
Copy link
Collaborator

emillon commented Sep 9, 2022

Duplicate of #5505

@emillon emillon marked this as a duplicate of #5505 Sep 9, 2022
@rgrinberg rgrinberg closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check that a test stanza is disabled before generating the rules voodoos/dune
3 participants
@samoht @rgrinberg @emillon