-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that a test stanza is disabled before generating the rules #6134
Conversation
d9e2a44
to
94ea351
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe the test and add a CHANGES entry.
94ea351
to
5e456e1
Compare
When a test is disabled dune shouldn't check the availability of its dependencies. Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
This is what is done for executables: no rule is generated if the enabled_if field evaluates to false. Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
5e456e1
to
3095ca7
Compare
Thanks for the review Rudi ! |
It's a dupe of #5529 isn't it? In which case the same review comment applies - we want to preserve the behavior and somehow version it or add a knob to |
It is in fact a duplicate... with exactly the same changes, so there is no reason to keep this PR open. |
Unlike the
executables
stanza, Dune attempted to create some rules for atests
even if it was disabled. This adds a similar check as the one forexecutables
to abort rule generation if the stanza is disabled.This should fix #6132