test(pkg): reproduce not finding the patch file (dune fmt)
#10947
Conversation
| > (public_name ocamlformat)) | ||
| > EOF | ||
| $ cd .. | ||
| $ tar -czf ocamlformat.tar.gz ocamlformat |
There was a problem hiding this comment.
Nitpick, but if you don't compress the tarball then you avoid a dependency on gzip.
There was a problem hiding this comment.
Wouldn't that mean ocamlformat directory could not be removed ?
There was a problem hiding this comment.
I don't understand. What I'm saying is, since you're using the z option in tar it will involve using gzip to pack the tarball and dune will use gzip to unpack the tarball. But given we don't really care about the size or distributing it, you can just create the tarball without compression, thus one less place where gzip is needed.
There was a problem hiding this comment.
OK I get it, fair point. Now this PR is using the helpers.sh file.
I think it would be better to remove the option z inside helpers.sh file in another PR, since the all ocamlformat tests are using it.
There was a problem hiding this comment.
I agree, opened #10952.
moyodiallo
force-pushed
the
test-for-bug-extra-files
branch
from
4c096d0
to
309a407
Compare
moyodiallo
changed the title
dune fmt)
| @@ -0,0 +1,71 @@ | |||
| This is a current bug, 'dune fmt' misses extra files from "dev-tools.locks" directory for the first run. | |||
There was a problem hiding this comment.
I don't really understand the bug from this description
There was a problem hiding this comment.
I'll rework it.
There was a problem hiding this comment.
I think it could be more comprehensible for now.
moyodiallo
force-pushed
the
test-for-bug-extra-files
branch
2 times, most recently
from
05f0596
to
f7e9b61
Compare
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
moyodiallo
force-pushed
the
test-for-bug-extra-files
branch
from
f7e9b61
to
9846505
Compare
|
The suggestions are applied, need another review here. |
| > EOF | ||
|
|
||
| Make the ocamlformat opam package which uses a patch: | ||
| $ mkpkg ocamlformat "0.26.2" <<EOF |
There was a problem hiding this comment.
Do you actually need the solving step? Can't you write a fake lock directory for ocamlformat?
There was a problem hiding this comment.
Yeah we need it. The bug is when the solving step is done during the fisrt run of dune fmt and if you have already the lock directory it won't trigger the bug.
It reproduce #10903.