refactor(pkg test): Avoid gzip on tarballs
#10952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moyodiallo
approved these changes
Sep 24, 2024
Leonidas-from-XIV
force-pushed
the
dont-gzip
branch
from
567301e
to
2e99b14
Compare
This avoids gzipping the tarballs that are created to test end to end functionality. Compressing and decompressing them takes time for minimal space saving so this PR just removes it. It retains the compression in the tarballs test, to make sure compressed tarballs continue to work. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
dont-gzip
branch
from
2e99b14
to
344633e
Compare
Sylvain78
pushed a commit
to Sylvain78/dune
that referenced
this pull request
Sep 25, 2024
This avoids gzipping the tarballs that are created to test end to end functionality. Compressing and decompressing them takes time for minimal space saving so this PR just removes it. It retains the compression in the tarballs test, to make sure compressed tarballs continue to work. Signed-off-by: Marek Kubica <marek@tarides.com> Signed-off-by: Sylvain78 <sylvain_kerjean@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids gzipping the tarballs that are created to test end to end functionality. Compressing and decompressing them takes time for minimal space saving so this PR just removes it.
It retains the compression in the tarballs test, to make sure compressed tarballs continue to work.