Be more forgiving with relative paths in search dirs #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
reviewed
Jan 4, 2022
|
To answer your question, yes we saw this crashing. However we are building in a very specific env:
|
yakobowski
force-pushed
the
master
branch
3 times, most recently
from
696ae2c
to
264b541
Compare
|
I rebased and pushed a minor variation which does not use |
We should only get absolute library paths in search dirs, but sometimes we currently get ./../lib. Accept this case Change-Id: I8c0710dcbe9c2c8690070a190f16c84025559dc3
|
Thank you for swift update! That looks great to me. No problem about the repro - I was only curious as to whether you'd got a "real" setup which hit this, or if you'd just noticed it reading the code. I shall shortly tag 0.40, which will include this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a search dir is relative and starts by '..', the current code is going
to crash. Instead, accept it without normalizing it.