Lwt 4.2.1 #13804
Merged
Lwt 4.2.1 #13804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☀️ All lint checks passed a46e6a0
☀️ Installability check (10920 → 10921)
|
kit-ty-kate
reviewed
Apr 2, 2019
| "seq" # seq is needed as long as Lwt supports OCaml < 4.07.0. | ||
|
|
||
| "bisect_ppx" {dev & >= "1.3.0"} | ||
| "ocamlfind" {dev & >= "1.7.3-1"} |
There was a problem hiding this comment.
This is not blocker at all but I'm curious why there is still a dependency on ocamlfind
There was a problem hiding this comment.
The PPX expect tests use it as an easy way of invoking the compiler.
kit-ty-kate
reviewed
Apr 2, 2019
| "cppo" {build & >= "1.1.0"} | ||
| "dune" {build} | ||
| "mmap" # mmap is needed as long as Lwt supports OCaml < 4.06.0. | ||
| "ocaml" {>= "4.02.0"} |
There was a problem hiding this comment.
Is this release also compatible with OCaml 4.08?
There was a problem hiding this comment.
It is since 4.2.0 (https://github.com/ocsigen/lwt/releases/tag/4.2.0)
There was a problem hiding this comment.
nevermind I didn't see the 4.2 release
|
Revdeps failures don't look too bad, some might be related but as it's only a small release I'm merging this now. Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small bugfix release.