Esy compatibility for libev detection #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll be able to take a good look in 48+ hours. We'll do a 4.2.1 release after fixing this (or is this something that can/should be patched in the esy overlay?). |
|
This would need a patch release, since we can't use Lwt + libev at all in esy with 4.2.0 right now. |
|
Thanks! |
|
Thank you. |
|
(FYI releasing this today to opam) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esy does not have an
opambinary in the path, and the libev detection introduced in c1e48e4 and released in 4.2.0 does not work with esy.The proposed fix defaults to looking for the environment variables that the libev packages for esy sets (https://github.com/esy-packages/libev/blob/master/package.json#L16-L26)