-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reftests: add tests to check url handling behaviours #5560
Conversation
to me, this looks fine. thanks for your work on this. |
Anything that can be done to get this merged? IMHO once this is merged, reviewing the related PRs is way easier. Again, thanks a lot for your work. :) |
@hannesm this is waiting on my review. This wasn't queued for 2.2.0 until a few days ago and i haven't had the time to look at it. We're having a meeting in 25 minutes so I'll ask a few question directly there. Mainly this PR is confusing to me as it includes fixes (3706ac3, 9bcdac8) whereas the PR was specifically made just to add tests-cases. I have no idea why these fixes are there and what they are doing so this is the main reason i did not do it yesterday |
774af93
to
58abe26
Compare
tests/reftests/local-cache.test
Outdated
echo "MD5: $md5" | ||
echo "SHA256: $sha256" | ||
echo "MD5: $(check "$MD5_PATH")" | ||
echo "SHA256: $(check "$SHA256_PATH")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn, Today I Learned
Thanks all! |
Three similar tests, one per each field: url, extra-sources & extra-files.
Each test check presence, checksum validation, and cache populating.
test introduced in #5538 is integrated in url test file.
/cc @hannesm @reynir
queued