-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opamfile: parse error on escapable paths #5562
base: master
Are you sure you want to change the base?
Conversation
3045578
to
ef84cd2
Compare
… more tied to --check-upstream option
This reverts commit e856756d5fbe0437b9123056da05785e96a3b46f.
ef84cd2
to
f1bbfc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A parse error on files is actually a pretty good idea, and a likely security improvement.
But enforcing the invariant at the OpamFilename
level seems pretty strict to me, I am afraid that it could break a few things. Couldn't that affect, for example, commands like opam pin ../foo/foo.opam
? Or is the path always resolved and made absolute soon enough ?
I looked at the last commit, and am convinced that it avoids |
Escapable path, containing
..
now raise a parse error.Removes lint 71 introduced in #5561
/cc @hannesm @reynir