Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix LTO issue #298

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Attempt to fix LTO issue #298

merged 4 commits into from
Aug 24, 2023

Conversation

wleoncio
Copy link
Member

I'm running gcc 12.3.0 here, but hopefully this change will also solve the issue on Ripley's machine (gcc 13.2.0). Otherwise, I could also try compiling on my laptop, which is probably on a more recently gcc version.

  • Increment version number to 1.3.1.9000
  • Changed run_testthat_tests() on RcppExports (CRAN failure #297)

This change was made automatically after rebuilding the current verstion
on master (tag v1.3.1) on my local machine (x86_64 GNU/Linux, gcc
12.3.0).
@wleoncio wleoncio requested a review from osorensen August 24, 2023 08:41
Since this is a hotfix, perhaps we should send it in as a new version.
@osorensen
Copy link
Collaborator

Thanks for doing this so quickly! I'll let all the tests complete running before merging.

Once it's done, could you please create another tarball, that includes my updates to cran-comments.md? I cannot build the package myself, because then it changes the fix back again...

@osorensen osorensen merged commit 7ec6036 into master Aug 24, 2023
@wleoncio wleoncio deleted the hotfix-1.3.2 branch August 24, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants