Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix LTO issue #298

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Attempt to fix LTO issue #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c18d52f
Increment version number to 1.3.1.9000
wleoncio Aug 24, 2023
59a36bf
Changed run_testthat_tests() on RcppExports (#297)
wleoncio Aug 24, 2023
9308daa
Updated patch version, NEWS.md
wleoncio Aug 24, 2023
f4824f4
Updated cran-comments
osorensen Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: BayesMallows
Type: Package
Title: Bayesian Preference Learning with the Mallows Rank Model
Version: 1.3.1
Version: 1.3.2
Authors@R: c(person("Oystein", "Sorensen",
email = "oystein.sorensen.1985@gmail.com",
role = c("aut", "cre"),
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# BayesMallows 1.3.2

* Fixed LTO compilation notes on CRAN.

# BayesMallows 1.3.1

* Fixed package documentation issue on CRAN.
Expand Down
2 changes: 1 addition & 1 deletion cran-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## Resubmission Note
This is a resubmission. It fixes a documentation issues, by creating an alias "BayesMallows-package". It also fixes some issues related to S3 methods which now generate NOTEs in r-devel, but have previously gone unnoticed.
This is a resubmission. It fixes an LTO issue caused by src/RcppExports.cpp.


## Test Environments
Expand Down
2 changes: 1 addition & 1 deletion src/RcppExports.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ BEGIN_RCPP
END_RCPP
}

RcppExport SEXP run_testthat_tests(void *);
RcppExport SEXP run_testthat_tests(SEXP);

static const R_CallMethodDef CallEntries[] = {
{"_BayesMallows_get_rank_distance", (DL_FUNC) &_BayesMallows_get_rank_distance, 3},
Expand Down