Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address check notes #14

Closed
16 of 17 tasks
wleoncio opened this issue Nov 26, 2021 · 3 comments
Closed
16 of 17 tasks

Address check notes #14

wleoncio opened this issue Nov 26, 2021 · 3 comments
Labels
blocked This issue depends on another issue being closed first bug Something isn't working

Comments

@wleoncio
Copy link
Member

wleoncio commented Nov 26, 2021 •
edited
Loading

On do.call.emjmcmc

  • do.call.emjmcmc: no visible binding for global variable ‘hashStat’
  • do.call.emjmcmc: no visible binding for global variable ‘mySearch’

On parallelize

  • parallelize: no visible binding for global variable ‘paral.type’

On runemjmcmc

  • runemjmcmc: no visible binding for global variable ‘data.example’
  • runemjmcmc: no visible binding for '<<-' assignment to ‘fparam.example’
  • runemjmcmc: no visible binding for '<<-' assignment to ‘mySearch’
  • runemjmcmc: no visible binding for global variable ‘mySearch’
  • runemjmcmc: no visible binding for global variable ‘fparam.example’
  • runemjmcmc: no visible binding for global variable ‘hashStat’
  • runemjmcmc: no visible binding for global variable ‘statistics’
  • runemjmcmc: no visible binding for global variable ‘statistics1’
  • runemjmcmc: no visible binding for global variable ‘hash.keys’
  • runemjmcmc: no visible binding for global variable ‘hash.keys1’
  • runemjmcmc: no visible binding for '<<-' assignment to ‘hash.keys1’
  • runemjmcmc: no visible binding for '<<-' assignment to ‘hash.keys’

On runpar.infer

  • runpar.infer: no visible binding for global variable ‘hashStat’
  • runpar.infer: no visible binding for global variable ‘mySearch’
@wleoncio wleoncio added the bug Something isn't working label Nov 26, 2021
@wleoncio
Copy link
Member Author

It's safest to wait for #8 to be closed before trying to fix this, since code changes may affect the function output.

@wleoncio wleoncio added the blocked This issue depends on another issue being closed first label Nov 26, 2021
wleoncio added a commit that referenced this issue Apr 20, 2022
@wleoncio
Resolved global notes on runemjmcmc (#14)
23126e3 
Credit to solution:
floybix/latticist#13 (comment).
wleoncio added a commit that referenced this issue Apr 20, 2022
@wleoncio
Resolved global assignments on mySearch (#14)
1309190 
Also, increment version number to 1.4.4.9011
wleoncio added a commit that referenced this issue May 2, 2022
@wleoncio
Resolved <<- on mySearch, adjusted tests (#14)
32e1100 
All the assignment left create some kind of test failure, so they should
be treated afterwards.
@wleoncio
Copy link
Member Author

wleoncio commented Aug 30, 2022 •
edited
Loading

mySearch is used completely within runemjmcmc(), so it should be eliminated as a generic object and instead be passed as an argument to the function.

  • Pass mySearch as argument to runemjmcmcm()

@wleoncio
Copy link
Member Author

The other global warnings have been programatically resolved, but perhaps it is better to recode them also as arguments to the functions that need them.

wleoncio added a commit that referenced this issue Nov 14, 2022
@wleoncio
Reversed assignment of globals (#14)
124333e 
Using `<<-` is the correct form of changing class values in the RC system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This issue depends on another issue being closed first bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wleoncio