Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add legacy switch to MADMM() #12

Closed
wleoncio opened this issue Nov 29, 2023 · 1 comment
Closed

Add legacy switch to MADMM() #12

wleoncio opened this issue Nov 29, 2023 · 1 comment
Assignees
@wleoncio
Labels
bug Something isn't working enhancement New feature or request

Comments

@wleoncio
Copy link
Member

The legacy switch to use the R code (see #2) is only present on the subfunction admm.MADMMplasso(). It should be moved upstream to its parent function, MADMM().
@wleoncio wleoncio added bug Something isn't working enhancement New feature or request labels Nov 29, 2023
@wleoncio wleoncio self-assigned this Nov 29, 2023
@wleoncio wleoncio mentioned this issue Nov 30, 2023
Merged
@wleoncio
Copy link
Member Author

wleoncio commented Dec 4, 2023

Resolved in c1dfb6a

@wleoncio wleoncio closed this as completed Dec 4, 2023
wleoncio added a commit that referenced this issue Dec 4, 2023
@wleoncio
Added documentation on legacy (#12)
624f07e
wleoncio added a commit that referenced this issue Dec 4, 2023
@wleoncio
Changed F to FALSE (#12)
66b1c9e 
CRAN standard requires booleans to be completely stated, i.e. `TRUE` and `FALSE` instead of `T` and `F`. The latter should be avoided, since they can cause confusion with similarly-named variables, not to mention are usually undetected by syntax highlighting.
wleoncio added a commit that referenced this issue Dec 4, 2023
@wleoncio
Removed redundancy (#12)
11edea6 
Nothing particularly wrong with using `legacy = legacy`, but if the rest
of the call doesn't use it, perhaps this argument shouldn't either.
@wleoncio wleoncio mentioned this issue Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wleoncio wleoncio

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wleoncio