Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor CRAN-related fixes #18

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Minor CRAN-related fixes #18

merged 4 commits into from
Dec 4, 2023

Conversation

wleoncio
Copy link
Member

@wleoncio wleoncio commented Dec 4, 2023

Just some minor adjustments to keep the package CRAN-compliant.

@wleoncio
Added documentation on legacy (#12)
624f07e
@wleoncio
Changed F to FALSE (#12)
66b1c9e 
CRAN standard requires booleans to be completely stated, i.e. `TRUE` and `FALSE` instead of `T` and `F`. The latter should be avoided, since they can cause confusion with similarly-named variables, not to mention are usually undetected by syntax highlighting.
@wleoncio
Removed redundancy (#12)
11edea6 
Nothing particularly wrong with using `legacy = legacy`, but if the rest
of the call doesn't use it, perhaps this argument shouldn't either.
@wleoncio
Increment version number to 0.0.0.9008
a82ed72
@wleoncio wleoncio added the documentation Improvements or additions to documentation label Dec 4, 2023
@wleoncio wleoncio requested a review from Theo-qua December 4, 2023 05:56
@Theo-qua Theo-qua merged commit d37cfc0 into main Dec 4, 2023
@wleoncio wleoncio deleted the minor-fixes branch December 4, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theo-qua Theo-qua Awaiting requested review from Theo-qua

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wleoncio @Theo-qua