-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving issues #17, #34, #42 #44
Conversation
This makes it more clear which engine (R or C++) should be used, potentially leading to fewer communications between the languages
It can't be easily suppressed otherwise
Removed and de-nested some definitions (#17)
This aims to align output with original R function
All CodeFactor issues are minor and most are not related to the issues mentioned here, so they should be worked on a different issue. |
All checks failing on parallel code:
Can reproduce locally, but only by running |
The solution might be simple and involve limiting the number of cores to 2 on the examples (source: https://stackoverflow.com/a/50571533/1169233). |
Windows gives errors regarding lack of support for fork clusters. This is to be eventually fixed separately.
Ready for review! Fixing the parallel test issues was as easy as setting |
C++ code has been confirmed to be faster than R, which should be enough to close issue #17 (and, by extension, #42).
Unit tests have been added for all valid combinations of
parallel
andpal
, which closes #34.