-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenPopup() overload with ImGuiID to ease opening modals from deeper stacks. #3993
Conversation
Hello, Thanks for the PR. Right now it doesn't make total sense to be using ID based We are contemplating exposing path-based ID stack manipulation, we have the code ready for it but I worry it would be confusing/error prone to only enable it on some functions, and I'm not sure we can afford to enable it on all functions. It consist in supporting three features:
The third feature makes lots of sense for some use (we use it a lot in the dev/automation project) but much less useful for popups and comes with some issues and is the one that's has the most perf impact, so if we omit it we could more easily adopt the top 2 features. The tricky thing is shall we only adopt them for Popup functions. Link #331 |
Thanks for the quick reply! I added the overload because I thought it would be better style than exposing the currently private OpenPopupEx(), but you are completely right. I didn't realize that pretty much no functions use IDs directly. Would it be ok to make public OpenPopupEx for now? I have a tree that is created with a recursive function, and each node has a button that can open a modal. For this use case, generating the id at the same level as the tree and then passing it down seems the best solution. (I could keep a flag around, but minimizing user side state is best, right?) About the path based ids, it sounds great. Just the first feature, having a global scope for for ids using "/" as leading characters would be super usefull. It falls on the user responsability to avoid global clashes but sounds reasonable. And performance wise would be quite cheap. |
You can forward-declare it anywhere in your code or just include
What's not clear to me is how you are calling BeginPopup then? |
Something Like this: doTree(ImGui::GetID("Add Node"));
if(ImGui::BeginPopupModal("Add Node", NULL, ImGuiWindowFlags_AlwaysAutoResize)) {
...
} I added it to the header because I thought it could be useful for other people trying to do the same. Instead of opening an Issue asking I made the PR as it was nearly the same. I'll keep using Feel free to close the PR! Thanks! |
You did totally right. Most PR are pointing at a meaningful issue. I thought about it more and realized that even with the proposed future additions, this will be useful so I merged this now. Thank you! |
As the title says, it's just a public overload for the OpenPopup() function with an ImGuiID parameter instead of string id.
Until a rework/rethinking of the popups is done, this helps to obtain the popup id at the same id stack level and then pass it down.