-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bastion fqdn with clusterID as subdmain #240
bastion fqdn with clusterID as subdmain #240
Conversation
Hi @schabrolles. Thanks for your PR. I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@yussufsh This PR is struck in Merge pool of Tide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@cs-zhang you had done similar changes with powervs automation. We can consider similar formats with powervm even for node names.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cs-zhang, schabrolles, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I notice that my bastion doesn't have the fqdn I was expected.
If my domain is
example.com
and my clusterID isocp4
the bastion fqdn is :ocp4-bastion-0.example.com
while I expect it to be :
ocp4-bastion-0.ocp4.example.com