Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go to 1.17 and related packages to latest #248

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Update go to 1.17 and related packages to latest #248

merged 1 commit into from
Mar 18, 2022

Conversation

Prajyot-Parab
Copy link
Contributor

Signed-off-by: Prajyot-Parab prajyot.parab2@ibm.com

@Prajyot-Parab
Update go to 1.17 and related packages to latest
8a98fce 
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2022
mkumatag
mkumatag approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2022
@mkumatag
Copy link
Member

@Rajalakshmi-Girish any idea why it taking so long to merge the PR?

@Rajalakshmi-Girish
Copy link

@Rajalakshmi-Girish any idea why it taking so long to merge the PR?

There are actually three PRs struck in Merge Pool.
https://prow.ppc64le-cloud.org/tide

Seems like the first PR in queue ocp-power-automation/ocp4-upi-powervm#240 needs two approvals with write access to Merge. Not sure why it has gone into the pool without getting the required number of approvals.

Similarly, ocp-power-automation/ocp4-upi-powervs#357 needs proper approvals is what I feel.
No info on these PRs in tide logs and no errors in the hook.

@mkumatag
Copy link
Member

/lgtm
/approve

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag mkumatag closed this Mar 18, 2022
@mkumatag mkumatag reopened this Mar 18, 2022
@mkumatag
Copy link
Member

Lemme merge manually for now!

@mkumatag mkumatag merged commit f8ae98d into ppc64le-cloud:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@bkhadars bkhadars Awaiting requested review from bkhadars

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Prajyot-Parab @mkumatag @Rajalakshmi-Girish @ppc64le-cloud-bot