Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize imports #176

Open
zuphilip opened this issue Jan 23, 2017 · 0 comments
Open

Standardize imports #176

zuphilip opened this issue Jan 23, 2017 · 0 comments

Comments

@zuphilip
Copy link
Collaborator

From #154 (comment) by @QuLogic :

I've got a branch that removes pylab imports; should I open a PR for that?

You mean https://github.com/QuLogic/ocropy/commits/standard-import? Sure, open a PR with the pertinent commits, looks really helpful, I'll happily merge/cherry-pick.

Yes, that's the one; though I just noticed that it's based on the Python 3 work, so it'll be a pain to cherry-pick. Should get that in ASAP and then the rest would be easier.

Maybe it is also now easier to redo the work which was done in the PRs, because the forks may be too different now.
@zuphilip zuphilip mentioned this issue Feb 1, 2017
Closed
@zuphilip zuphilip mentioned this issue Apr 28, 2017
Merged
kba added a commit that referenced this issue Sep 29, 2017
@kba
Merge pull request #206 from zuphilip/imports
d823ba4 
Standardize Imports I, #176
@SaikrishnaViridis SaikrishnaViridis mentioned this issue Oct 16, 2017
Closed
zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 19, 2017
@zuphilip
Standardize imports for edist.py ocropus-archive#176
ea584d0
zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 19, 2017
@zuphilip
Standardize imports for edist.py ocropus-archive#176
5a71411
zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 27, 2017
@zuphilip
Standardize imports for lineest.py, psegutils.py ocropus-archive#176
6870fa3 
Both files are covered good by the current tests and
all tests are still fine with these changes.

This work is heavily based on the work by @QuLogic in the branch
https://github.com/QuLogic/ocropy/commits/standard-import
zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 27, 2017
@zuphilip
Standardize numpy imports in more files ocropus-archive#176
dfb5a54 
These replacements are easy.
zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 27, 2017
@zuphilip
Standardize imports for lineest.py, psegutils.py ocropus-archive#176
ffd24e9 
Both files are covered good by the current tests and
all tests are still fine with these changes.

This work is heavily based on the work by @QuLogic in the branch
https://github.com/QuLogic/ocropy/commits/standard-import
zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 27, 2017
@zuphilip
Standardize numpy imports in more files ocropus-archive#176
056c461 
These replacements are easy.
zuphilip added a commit that referenced this issue Feb 19, 2018
@zuphilip
Merge pull request #282 from zuphilip/edist-py-imports
d3e5cc6 
Standardize imports II, #176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zuphilip