Standardize imports II, #176 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Dec 19, 2017
ocrolib/edist.py
Outdated
| sources[:,:] = None | ||
| dists = 99999*ones((m+1,n+1)) | ||
| dists[0,:] = arange(n+1) | ||
| dists = 99999*np.ones((m+1,n+1)) |
There was a problem hiding this comment.
np.full((m + 1, n + 1), 99999)
|
In lstm.py this form is used:
This patch uses the np namespace. Why the difference? |
|
This one is a de facto standard; I dunno why |
zuphilip
force-pushed
the
edist-py-imports
branch
from
ea584d0
to
5a71411
Compare
|
I don't have a problem with using the np namespace, but just wanted to point to the inconsistency. |
zuphilip
changed the title
Both files are covered good by the current tests and all tests are still fine with these changes. This work is heavily based on the work by @QuLogic in the branch https://github.com/QuLogic/ocropy/commits/standard-import
These replacements are easy.
zuphilip
force-pushed
the
edist-py-imports
branch
from
dfb5a54
to
bfb001d
Compare
|
Please have a look at the new version of this PR. This should be ready to review now. (There are more files where the imports could be standardized, but maybe we can first make better tests for them. This could be done in some future PRs.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @Hyper-Node