Fix DateTimeOffset as Variable #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 78.83% 78.84% +0.01%
==========================================
Files 73 73
Lines 2447 2449 +2
Branches 357 358 +1
==========================================
+ Hits 1929 1931 +2
Misses 441 441
Partials 77 77
|
LordJZ
commented
Apr 6, 2020
Comment on lines
+84
to
+100
| [IntegrationTest] | ||
| public async Task DateTime_Filter_Works() | ||
| { | ||
| var query = new GraphQL.Query() | ||
| .Viewer.ContributionsCollection(from: Variable.Var("start")) | ||
| .Select(c => c.User.Name); | ||
|
|
||
| var vars = new Dictionary<string, object> | ||
| { | ||
| { "start", new DateTimeOffset(2000, 1, 2, 3, 4, 5, default) } | ||
| }; | ||
|
|
||
| var response = await Connection.Run(query.Compile(), vars); | ||
|
|
||
| // no server error | ||
| Assert.NotNull(response); | ||
| } |
There was a problem hiding this comment.
any better location for this?
Comment on lines
+321
to
+340
| [Fact] | ||
| public void DateTimeOffsetVariable() | ||
| { | ||
| var expected = @"query($start: DateTime) { | ||
| user(login: ""grokys"") { | ||
| contributionsCollection(from: $start) { | ||
| latestRestrictedContributionDate | ||
| } | ||
| } | ||
| }"; | ||
|
|
||
| var expression = new Query() | ||
| .User("grokys") | ||
| .ContributionsCollection(@from: Variable.Var("start")) | ||
| .Select(c => c.LatestRestrictedContributionDate); | ||
|
|
||
| var query = expression.Compile(); | ||
|
|
||
| Assert.Equal(expected, query.ToString(), ignoreLineEndingDifferences: true); | ||
| } |
There was a problem hiding this comment.
I could put this into Core like in #214, but I need a DateTimeOffset parameter for this
|
@jcansdale Looks good to me, either this pull request or #226 can be merged to add support for DateTimeOffset as variable. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.