Add support for DateTime in queries #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 78.83% 78.84% +0.01%
==========================================
Files 73 73
Lines 2447 2449 +2
Branches 357 358 +1
==========================================
+ Hits 1929 1931 +2
Misses 441 441
Partials 77 77
|
|
Sorry @0xced -- I was running into a couple different issues while merging. This is now completed |
0xced
force-pushed
the
query-datetime-support
branch
from
bd8c66c
to
1c0e431
Compare
Note: the [DateTime][1] scalar type is [mapped to System.DateTimeOffset][2] in the model generator. The motivation behind this change is that you need to set `from` and `to` in order to [get more than one year of contributions][3]. [1]: https://developer.github.com/v4/scalar/datetime/ [2]: https://github.com/octokit/octokit.graphql.net/blob/285fc1b2ce0b2dde72a4fa6abb5154778bbbe86d/Octokit.GraphQL.Core.Generation/Utilities/TypeUtilities.cs#L131 [3]: https://git.luolix.topmunity/t5/GitHub-API-Development-and/Are-pullRequestContributions-limited/m-p/32096#M3044
0xced
force-pushed
the
query-datetime-support
branch
from
1c0e431
to
3da1ebe
Compare
|
Closing this in favor of: #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QuerySerializer would generate a stack overflow without a special case for the
DateTimeOffsettype.Note: the DateTime scalar type is mapped to System.DateTimeOffset in the model generator.
The motivation behind this change is that you need to set
fromandtoin order to get more than one year of contributions.