fix(logging): change error to warn (#801)

* fix(logging): change error to warn * tests: adapt for changes Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
octokit · Jan 14, 2023 · f25154a · f25154a
1 parent 60a3102
commit f25154a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -62,7 +62,7 @@ class Webhooks<TTransformed = unknown> {
     this.sign = sign.bind(null, options.secret);
     this.verify = (eventPayload: object | string, signature: string) => {
       if (typeof eventPayload === "object") {
-        console.error(
+        console.warn(
           "[@octokit/webhooks] Passing a JSON payload object to `verify()` is deprecated and the functionality will be removed in a future release of `@octokit/webhooks`"
         );
       }
@@ -79,7 +79,7 @@ class Webhooks<TTransformed = unknown> {
         | EmitterWebhookEventWithSignature
     ) => {
       if (typeof options.payload === "object") {
-        console.error(
+        console.warn(
           "[@octokit/webhooks] Passing a JSON payload object to `verifyAndReceive()` is deprecated and the functionality will be removed in a future release of `@octokit/webhooks`"
         );
       }

diff --git a/src/middleware/node/get-payload.ts b/src/middleware/node/get-payload.ts
@@ -20,7 +20,7 @@ export function getPayload(
 
   if (request.body) {
     if (typeof request.body !== "string") {
-      console.error(
+      console.warn(
         "[@octokit/webhooks] Passing the payload as a JSON object in `request.body` is deprecated and will be removed in a future release of `@octokit/webhooks`, please pass it as a a `string` instead."
       );
     }

diff --git a/src/middleware/node/index.ts b/src/middleware/node/index.ts
@@ -13,7 +13,7 @@ export function createNodeMiddleware(
   }: MiddlewareOptions = {}
 ) {
   const deprecateOnUnhandledRequest = (request: any, response: any) => {
-    console.error(
+    console.warn(
       "[@octokit/webhooks] `onUnhandledRequest()` is deprecated and will be removed in a future release of `@octokit/webhooks`"
     );
     return onUnhandledRequest(request, response);

diff --git a/test/unit/deprecation.test.ts b/test/unit/deprecation.test.ts
@@ -19,7 +19,7 @@ describe("Deprecations", () => {
     );
   });
   test("onUnhandledRequest", async () => {
-    const spy = jest.spyOn(console, "error");
+    const spy = jest.spyOn(console, "warn");
     const webhooks = new Webhooks({
       secret: "mySecret",
     });
@@ -54,7 +54,7 @@ describe("Deprecations", () => {
   });
 
   test("webhooks.verify(payload, signature) with object payload", async () => {
-    const spy = jest.spyOn(console, "error");
+    const spy = jest.spyOn(console, "warn");
     const secret = "mysecret";
     const webhooks = new Webhooks({ secret });
 
@@ -69,7 +69,7 @@ describe("Deprecations", () => {
   });
 
   test("webhooks.verifyAndReceive(payload, signature) with object payload", async () => {
-    const spy = jest.spyOn(console, "error");
+    const spy = jest.spyOn(console, "warn");
     const secret = "mysecret";
     const webhooks = new Webhooks({ secret });