Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): change error to warn #801

Merged
merged 3 commits into from
Jan 14, 2023
Merged

fix(logging): change error to warn #801

merged 3 commits into from
Jan 14, 2023

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Jan 13, 2023

Resolves #790 (comment)


Behavior

Before the change?

  • Logging would use error, which could make jest confused.

After the change?

  • Use warn for logging

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented, or is being fixed label Jan 13, 2023
gr2m
gr2m previously approved these changes Jan 13, 2023
@wolfy1339 wolfy1339 enabled auto-merge (squash) January 13, 2023 17:06
@wolfy1339

This comment was marked as resolved.

@wolfy1339 wolfy1339 merged commit f25154a into main Jan 14, 2023
@wolfy1339 wolfy1339 deleted the change-error-to-warn branch January 14, 2023 20:35
@github-actions
Copy link
Contributor

🎉 This PR is included in version 10.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants