Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: registry_package is missing installation object #812

Closed
1 task done
ZauberNerd opened this issue Jun 28, 2023 · 2 comments · Fixed by #813
Closed
1 task done

[BUG]: registry_package is missing installation object #812

ZauberNerd opened this issue Jun 28, 2023 · 2 comments · Fixed by #813
Labels
released Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@ZauberNerd
Copy link
Contributor

What happened?

The schema for registry_package events (RegistryPackagePublishedEvent and RegistryPackageUpdatedEvent) are missing the installation object.

The documentation lists installation as object: https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#registry_package

Versions

@octokit/webhooks-types@5.8.0 (included with probot)
@octokit/webhooks-types@7.0.3 (latest)

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ZauberNerd ZauberNerd added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jun 28, 2023
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone Priority: Normal and removed Status: Triage This is being looked at and prioritized labels Jun 28, 2023
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Jun 28, 2023
wolfy1339 added a commit that referenced this issue Jun 29, 2023
@wolfy1339
fix: add missing installation key to registry_packag and `package…
79c0951 
…` events

Fixes #812
@wolfy1339 wolfy1339 linked a pull request Jun 29, 2023 that will close this issue
feat: new and updated payload examples with resulting schema changes #813
Merged
5 tasks
@wolfy1339 wolfy1339 mentioned this issue Jun 29, 2023
Merged
5 tasks
@wolfy1339
Copy link
Member

I have lumped this in to my update PR in #813

wolfy1339 added a commit that referenced this issue Jun 29, 2023
@wolfy1339
feat: new and updated payload examples with resulting schema changes (#…
9f7f7f3 
…813)

* fix: update events for Apps and webhooks

* fix: mark `fixed_in` as not required for `repository_vulnerability` events

* feat: new `topics` key for `changes` on `repository.edited` event

* feat: new auto dismissal of dependabot alerts

* feat: new `notification_setting` key on team

* feat: new `queued` status for workflow jobs

* build: generate types

* feat: new `dependabot_alert.created` example payload

* chore: update payloads to reflect schema changes

* feat: new payload example to demonstrate `queued` steps in a workflow job

* build: generate index.json

* fix: `id` in nugget package metadata cannot be an object

* build: generate types

* fix: add missing `additionalProperties: false`

* fix: add missing `installation` key to `registry_packag` and `package` events

Fixes #812
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Jun 29, 2023
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: new and updated payload examples with resulting schema changes octokit/webhooks
4 participants
@ZauberNerd @wolfy1339 @kfcampbell @octokitbot