-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new and updated payload examples with resulting schema changes #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you go about doing this? How come it wasn't caught by the update script?
The update script is broken because of the switch in the GitHub docs to the OpenAPI spec, and because the examples have been removed. |
I have a webhooks endpoint running on my server that compares incoming webhooks to the schema defined in this repo. It was originally implemented by @G-Rath, as a serverless function to run on Azure, and I modified it to run on express. https://github.com/G-Rath/compare-gh-webhook-to-schema-function |
🎉 This PR is included in version 7.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@wolfy1339 fwiw I don't mind migrating the original app to Express/Koa if you like - the serverless function has been shutdown anyway, and it'd give me something to do 🤷 |
Resolves #812
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Feature