Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payload–examples): add "installation" field to pull_request-* payload examples #137

Merged
merged 3 commits into from
Aug 3, 2020
Merged

fix(payload–examples): add "installation" field to pull_request-* payload examples #137

merged 3 commits into from
Aug 3, 2020

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Aug 3, 2020

📝 Summary

Add "installation" field to pull_request.* payload examples

⛱ Motivation and Context

Fixes octokit/webhooks.js#176
Fix #138

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Oscar! I've added prettier linting to the example JSON files, that way we will see less unrelated diffs in future pull requests to the example paylaods

@gr2m gr2m added the Type: Bug Something isn't working as documented label Aug 3, 2020
@gr2m gr2m changed the title 🐛 fix(payload–examples): add "installation" field to pull_request-* payload examples fix(payload–examples): add "installation" field to pull_request-* payload examples Aug 3, 2020
@gr2m
Copy link
Contributor

gr2m commented Aug 3, 2020

btw the emoji are fun in comments and descriptions, but I have to remove them from the beginning of commit messages because of semantic-release

@gr2m gr2m merged commit b4ece11 into octokit:master Aug 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2020

🎉 This PR is included in version 3.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
2 participants