Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support list of anchor names #178

Merged
merged 3 commits into from
May 29, 2024
Merged

Support list of anchor names #178

merged 3 commits into from
May 29, 2024

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented May 15, 2024

Description

The spec now supports a list of anchor-name values, for instance anchor-name: --a, --b;.

Related Issue(s)

n/a

Steps to test/reproduce

Check the demo page, apply the polyfill, and see that two targets can use different anchor names to target the same anchor element.

Also fixes WPT test css/css-anchor-position/anchor-name-004.html.

Show me

image

@jamesnw jamesnw requested a review from jgerigmeyer May 15, 2024 16:53
Copy link

netlify bot commented May 15, 2024

Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit deda1ab
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/66462f0ecf870400085d58f9
😎 Deploy Preview https://deploy-preview-178--anchor-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit deda1ab
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/66462f0eeba11700080554e2

Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

src/parse.ts Outdated Show resolved Hide resolved
@jamesnw jamesnw linked an issue May 17, 2024 that may be closed by this pull request
@jamesnw jamesnw merged commit 6aafdf7 into main May 29, 2024
10 checks passed
@jamesnw jamesnw deleted the anchor-name-list branch May 29, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anchor-name supports a list of values
2 participants