Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support list of anchor names #178

Merged
merged 3 commits into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ following:
- anchor functions with `implicit` anchor-element
- automatic anchor positioning: anchor functions with `inside` or `outside`
anchor-side
- `anchor-name` property defining multiple anchor names
- `position-visibility` property
- dynamically added/removed anchors or targets
- anchors or targets in the shadow-dom
Expand Down
33 changes: 33 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<link rel="stylesheet" href="/anchor-size.css" />
<link rel="stylesheet" href="/anchor-math.css" />
<link rel="stylesheet" href="/anchor-name-custom-prop.css" />
<link rel="stylesheet" href="/anchor-name-list.css" />
<link rel="stylesheet" href="/anchor-custom-props.css" />
<link rel="stylesheet" href="/anchor-duplicate-custom-props.css" />
<link rel="stylesheet" href="/anchor-implicit.css" />
Expand Down Expand Up @@ -664,6 +665,38 @@ <h2>
right: anchor(--my-anchor-update right);
top: anchor(--my-anchor-update bottom);
}</code></pre>
</section>
<section id="anchor-name-list" class="demo-item">
<h2>
<a href="#anchor-name-list" aria-hidden="true">🔗</a>
Use a list of anchor names
</h2>
<div style="position: relative" class="demo-elements">
<div id="my-anchor-name-list" class="anchor">Anchor</div>
<div id="my-target-name-list-a" class="target">Target A</div>
<div id="my-target-name-list-b" class="target">Target B</div>
</div>
<p class="note">
With polyfill applied: Target A is positioned at Anchor's top left
corner. Target B is positioned at Anchor's bottom right corner.
</p>
<pre><code class="language-css"
>#my-anchor-name-list {
anchor-name: --my-anchor-name-a, --my-anchor-name-b;
}

#my-target-name-list-a {
position: absolute;
right: anchor(--my-anchor-name-a left);
bottom: anchor(--my-anchor-name-a top);
}

#my-target-name-list-b {
position: absolute;
left: anchor(--my-anchor-name-b right);
top: anchor(--my-anchor-name-b bottom);
}
</code></pre>
</section>
<section id="sponsor">
<h2>Sponsor OddBird's OSS Work</h2>
Expand Down
15 changes: 15 additions & 0 deletions public/anchor-name-list.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#my-anchor-name-list {
anchor-name: --my-anchor-name-a, --my-anchor-name-b;
}

#my-target-name-list-a {
position: absolute;
right: anchor(--my-anchor-name-a left);
bottom: anchor(--my-anchor-name-a top);
}

#my-target-name-list-b {
position: absolute;
left: anchor(--my-anchor-name-b right);
top: anchor(--my-anchor-name-b bottom);
}
29 changes: 16 additions & 13 deletions src/parse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,12 @@ function getAnchorNameData(node: csstree.CssNode, rule?: csstree.Raw) {
node.value.children.first &&
jamesnw marked this conversation as resolved.
Show resolved Hide resolved
rule?.value
) {
const name = (node.value.children.first as csstree.Identifier).name;
return { name, selector: rule.value };
return node.value.children.map((item) => {
const { name } = item as csstree.Identifier;
return { name, selector: rule.value };
});
}
return {};
return [];
}

let anchorNames: AnchorNames = {};
Expand Down Expand Up @@ -559,17 +561,18 @@ export async function parseCSS(styleData: StyleData[]) {
const rule = this.rule?.prelude as csstree.Raw | undefined;

// Parse `anchor-name` declaration
const { name: anchorName, selector: anchorSelector } = getAnchorNameData(
node,
rule,
const anchorNameData = getAnchorNameData(node, rule);
anchorNameData.forEach(
({ name: anchorName, selector: anchorSelector }) => {
if (anchorName && anchorSelector) {
if (anchorNames[anchorName]) {
anchorNames[anchorName].push(anchorSelector);
} else {
anchorNames[anchorName] = [anchorSelector];
}
}
},
);
if (anchorName && anchorSelector) {
if (anchorNames[anchorName]) {
anchorNames[anchorName].push(anchorSelector);
} else {
anchorNames[anchorName] = [anchorSelector];
}
}

// Parse `anchor()` function
const {
Expand Down
60 changes: 60 additions & 0 deletions tests/unit/parse.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,66 @@ describe('parseCSS', () => {
expect(rules).toEqual(expected);
});

it('parses `anchor-name` with a list of names', async () => {
document.body.innerHTML =
'<div style="position: relative"><div id="my-anchor-name-list"></div><div id="my-target-name-list-a"></div><div id="my-target-name-list-b"></div></div>';
const css = getSampleCSS('anchor-name-list');
document.head.innerHTML = `<style>${css}</style>`;
const { rules } = await parseCSS([{ css }] as StyleData[]);
const expected = {
'#my-target-name-list-a': {
declarations: {
right: [
{
anchorSide: 'left',
anchorEl: document.getElementById('my-anchor-name-list'),
targetEl: document.getElementById('my-target-name-list-a'),
anchorName: '--my-anchor-name-a',
fallbackValue: '0px',
uuid: expect.any(String),
},
],
bottom: [
{
anchorSide: 'top',
anchorEl: document.getElementById('my-anchor-name-list'),
targetEl: document.getElementById('my-target-name-list-a'),
anchorName: '--my-anchor-name-a',
fallbackValue: '0px',
uuid: expect.any(String),
},
],
},
},
'#my-target-name-list-b': {
declarations: {
left: [
{
anchorSide: 'right',
anchorEl: document.getElementById('my-anchor-name-list'),
targetEl: document.getElementById('my-target-name-list-b'),
anchorName: '--my-anchor-name-b',
fallbackValue: '0px',
uuid: expect.any(String),
},
],
top: [
{
anchorSide: 'bottom',
anchorEl: document.getElementById('my-anchor-name-list'),
targetEl: document.getElementById('my-target-name-list-b'),
anchorName: '--my-anchor-name-b',
fallbackValue: '0px',
uuid: expect.any(String),
},
],
},
},
};

expect(rules).toEqual(expected);
});

it('parses `anchor()` function (math)', async () => {
document.body.innerHTML =
'<div style="position: relative"><div id="my-target-math"></div><div id="my-anchor-math"></div></div>';
Expand Down
Loading