Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipwbConfig should be renamed to ipwbUtils #392

Closed
ibnesayeed opened this issue Jun 21, 2018 · 0 comments
Closed

ipwbConfig should be renamed to ipwbUtils #392

ibnesayeed opened this issue Jun 21, 2018 · 0 comments
Labels
Code/Project quality enhancement good-first-issue

Comments

@ibnesayeed
Copy link
Member

ipwb/ipwb/replay.py

Line 40 in 40bcb3d

import util as ipwbConfig

As the util.py file evolved, many helper functions in it are no longer related to configuration, hence the name is now confusing. When this change is made, any usage of ipwbConfig should also be replaced with ipwbUtils in the whole file.
machawk1 added a commit that referenced this issue Jul 8, 2018
@machawk1
Merge pull request #420 from oduwsdl/issue-392
d44a613 
Refactor ipwb util import alias. Closes #392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code/Project quality enhancement good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ibnesayeed