-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Markdown formatting issues after conversion from RST #422
Conversation
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
=======================================
Coverage 23.29% 23.29%
=======================================
Files 6 6
Lines 1112 1112
Branches 169 169
=======================================
Hits 259 259
Misses 836 836
Partials 17 17 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I am not a big fan of the underline in the sections as added when we promote the headings per your edits but it results in more structured markup (H2 instead of H3), so I suppose I will relent fighting GH's MD->HTML/CSS style.
That change was made mainly due to semantic reasons, not stylistic. I had no problem with them being H3, but there was no H2 in the hierarchy. I have noted two issues, 1) DH breaks lines in rendering when there is a line break in the source (docker/hub-feedback#320 (comment)) and PyPi eats up leading zeros from the hour-minute combo (e.g., |
I have been aware of the latter (PyPi versioning) issue since we started pushing it there and encountered a date with a leading 0. The leading 0 keeps lexical positioning sorting, so I have retained using that style despite PyPi's behavior. |
PyPi should take version number as opaque string though. |
I completely agree though maybe they do it on the PEP-440 rationale:
|
On the contrary, same PEP:
|
I came to know the reasoning behind this because they wanted to ensure |
Mainly fixed language annotations in code blocks as noted in #399.