Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the README.rst to .md to prettify the dockerhub display #399

Closed
machawk1 opened this issue Jun 22, 2018 · 13 comments · Fixed by #438
Closed

Convert the README.rst to .md to prettify the dockerhub display #399

machawk1 opened this issue Jun 22, 2018 · 13 comments · Fixed by #438

Comments

@machawk1
Copy link
Member

https://hub.docker.com/r/oduwsdl/ipwb/

...shows the symbols used for linking and formatting in https://github.com/oduwsdl/ipwb/blob/master/README.rst. RST was originally used for display in pypi. Pypi has since had a UI overhaul. Is the markdown support any better? If so, we might try to move to MD for the sake of readability in dockerhub. Alternatively, we might look to finding a way to ensure the README does not contain the meta content and still use the README.rst.

@machawk1 machawk1 changed the title Find a way to prettify the README in dockerhub Find a way to prettify the README in dockerhub while staying pypi compatible Jun 22, 2018
@ibnesayeed
Copy link
Member

Looks like the proposal to support Markdown in PyPi is finally implemented.

https://dustingram.com/articles/2018/03/16/markdown-descriptions-on-pypi

@machawk1 machawk1 changed the title Find a way to prettify the README in dockerhub while staying pypi compatible Convert the README.rst to .md to prettify the dockerhub display Jun 24, 2018
machawk1 added a commit that referenced this issue Jul 8, 2018
@machawk1
Copy link
Member Author

machawk1 commented Jul 8, 2018

@ibnesayeed The README has been updated to MD and displays fine in GitHub and PyPi. Dockerhub seems to choke, however. Can you figure out what, if anything, Dockerhub requires differently than GitHub and PyPi in its MD?

@ibnesayeed
Copy link
Member

GH is more versatile in parsing different common documentation formats, but DH is more limited to a more strict MD format. That's why current mixed up MD file is not rendering there properly, especially the way code blocks are annotated. If you want to take care of these then go ahead otherwise let me know and I will try to fix them and push a commit.

@machawk1
Copy link
Member Author

machawk1 commented Jul 8, 2018

Does an interface exist where I can test how MD will be rendered on Dockerhub?

Go ahead and try to fix them if you can without changing the visual display of the GitHub/PyPi document. If that's not possible (i.e., DockerHub MD restriction prevents some GH-MD feature), let me know.

@ibnesayeed
Copy link
Member

ibnesayeed commented Jul 8, 2018

No, I don't think they have a preview option, but I am sure I can fix it. I will work on this and push changes to the issue-399 branch. If those changes don't work well, then we can revert them.

@machawk1
Copy link
Member Author

@ibnesayeed I recall you mentioning display issues with the README on DockerHub within some other repo. Can you link it here? The line breaking on the DockerHub version of the ipwb README contains odd line breaking, mis-aligned consecutive code blocks, etc.

@ibnesayeed
Copy link
Member

Line breaking in the DH rendering is a long-known issue docker/hub-feedback#124. If we want to fix that now and make it consistent across all three places, we can just remove all the newlines from the MD source where they are not needed.

I have reported the misaligned consecutive code lines issue docker/hub-feedback#988 (comment).

@machawk1
Copy link
Member Author

@ibnesayeed I was wondering what you meant by the first statement, checked out the README.md and noticed superfluous line breaks to a line width (maybe 80-chars?). This may have been the result of the RST->MD conversion script, as I am not prone to manually applying this sort of line breaking to free-form text (code is a different story).

@ibnesayeed
Copy link
Member

Oh, I didn't know you used a conversion script. I am sure the fixed width text is a result of that. I did not change that, because I thought you did it intentionally. I can go ahead and make that change now.

@machawk1
Copy link
Member Author

@ibnesayeed Do you think we can close this ticket or is more adjustment needed?

@ibnesayeed
Copy link
Member

There is one little thing that I will fix and close this.

@machawk1
Copy link
Member Author

Oh, right, is it the extra CRLF?

@ibnesayeed
Copy link
Member

Oh, right, is it the extra CRLF?

Yes!

This should be sorted out by the #438 PR.

@machawk1 machawk1 removed the pending label Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants