Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixed-width formatting of README #431

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Remove fixed-width formatting of README #431

merged 1 commit into from
Jul 10, 2018

Conversation

ibnesayeed
Copy link
Member

DH rendering breaks lines when there are newlines in the MD source (as discussed in #399).

@ibnesayeed ibnesayeed requested a review from machawk1 July 10, 2018 17:44
Copy link
Member

@machawk1 machawk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@machawk1 machawk1 merged commit e06d502 into master Jul 10, 2018
@machawk1 machawk1 deleted the issue-399 branch July 10, 2018 18:04
@machawk1
Copy link
Member

machawk1 commented Jul 10, 2018

@ibnesayeed Does DockerHub pull from source on a release or a change in the repo? I would like to hold off on pushing another release (even if this is required for DockerHub to regenerate) until we have a functional change.

@ibnesayeed
Copy link
Member Author

DH generally updates its README and Dockerfile render based on the last successful build. So, it should be fixed there already. No need for a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants