Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events module: serialize only specific fields of related objects #2324

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Jul 25, 2024

Proposed Changes

  • update field serialization logic
  • add sorting by the new taken at field
  • autoload event types on start

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak requested a review from a team as a code owner July 25, 2024 18:21
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 63.82979% with 17 lines in your changes missing coverage. Please review.

Project coverage is 63.71%. Comparing base (763043a) to head (e8bb962).

Files Patch % Lines
care/utils/event_utils.py 13.33% 13 Missing ⚠️
care/facility/events/handler.py 70.00% 3 Missing ⚠️
care/users/models.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2324      +/-   ##
===========================================
- Coverage    63.73%   63.71%   -0.03%     
===========================================
  Files          238      238              
  Lines        13353    13376      +23     
  Branches      1907     1906       -1     
===========================================
+ Hits          8511     8522      +11     
- Misses        4490     4504      +14     
+ Partials       352      350       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak force-pushed the sainak/feat/event-related-field-serialization branch from 7f50553 to 81c1d58 Compare July 26, 2024 09:25
@sainak sainak requested a review from vigneshhari July 29, 2024 08:23
@nihal467
Copy link
Member

nihal467 commented Jul 30, 2024

@sainak
image

the events is throwing 500 error, [ this patient is not having any events ]

@nihal467
Copy link
Member

nihal467 commented Aug 7, 2024

@sainak the PR looks good to me and is ready for peer review, can you get the frontend PR for ohcnetwork/care_fe#8046

@nihal467 nihal467 added the P1 High priority; urgent label Aug 8, 2024
@gigincg gigincg merged commit ee747c6 into develop Aug 8, 2024
10 of 11 checks passed
@gigincg gigincg deleted the sainak/feat/event-related-field-serialization branch August 8, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events Module: Diagnosis Show only relevant detail of ICD-11 in events log
6 participants