Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sorting for events #8270

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Added sorting for events #8270

merged 4 commits into from
Aug 9, 2024

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar requested a review from a team as a code owner August 8, 2024 07:49
@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 5:10am

@netlify Netlify
Copy link

netlify bot commented Aug 8, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e1237ac
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66b5a49541eb6e00080c698e
😎 Deploy Preview https://deploy-preview-8270--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Aug 8, 2024 •
edited
Loading


Test summary

126 • 0 • 0 • 0

Run details
Project CARE
Status Passed
Commit e1237ac
Started Aug 9, 2024 5:14 AM
Ended Aug 9, 2024 5:17 AM
Duration 02:58 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@khavinshankar khavinshankar added needs testing reviewed reviewed by a core member labels Aug 8, 2024
@nihal467
Copy link
Member

nihal467 commented Aug 8, 2024

waiting for the fix of #8276

@nihal467 nihal467 added the waiting for related PR a co-related detail PR is under construction label Aug 8, 2024
@nihal467 nihal467 removed the waiting for related PR a co-related detail PR is under construction label Aug 8, 2024
@nihal467
Copy link
Member

nihal467 commented Aug 8, 2024 •
edited by khavinshankar
Loading

image

  • make the sort by time taken more human-readable format

@nihal467 nihal467 added tested changes required urgent P1 breaking issue or vital feature and removed needs testing tested labels Aug 8, 2024
@nihal467
Copy link
Member

nihal467 commented Aug 9, 2024

LGTM

@gigincg gigincg merged commit f5721b9 into develop Aug 9, 2024
60 of 61 checks passed
@gigincg gigincg deleted the sort-events branch August 9, 2024 05:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

@khavinshankar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@shivankacker shivankacker shivankacker approved these changes

@sainak sainak Awaiting requested review from sainak

Assignees
No one assigned
Labels
P1 breaking issue or vital feature reviewed reviewed by a core member tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort log update events by taken at time rather than event created at time
5 participants
@khavinshankar @nihal467 @shivankacker @rithviknishad @gigincg