Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-build sidebar UI #8680

Merged
merged 17 commits into from
Oct 8, 2024
Merged

Re-build sidebar UI #8680

merged 17 commits into from
Oct 8, 2024

Conversation

bodhish
Copy link
Member

@bodhish bodhish commented Oct 1, 2024

  • Clean up custom screen size
  • Update styles for the navbar
  • Add an Avatar component

image

@bodhish bodhish requested a review from a team as a code owner October 1, 2024 05:51
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 1d334b4
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6702fa7bee4a1400082f0c88
😎 Deploy Preview https://deploy-preview-8680--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d334b4
Status: ✅  Deploy successful!
Preview URL: https://e905b1bc.care-fe.pages.dev
Branch Preview URL: https://patient-form-rebuild.care-fe.pages.dev

View logs

Copy link

cypress bot commented Oct 1, 2024

CARE    Run #3544

Run Properties:  status check passed Passed #3544  •  git commit 1d334b4eba: Re-build sidebar UI
Project CARE
Branch Review patient-form-rebuild
Run status status check passed Passed #3544
Run duration 03m 09s
Commit git commit 1d334b4eba: Re-build sidebar UI
Committer Bodhish Thomas
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 124
View all changes introduced in this branch ↗︎

@bodhish bodhish mentioned this pull request Oct 2, 2024
6 tasks
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

👋 Hi, @bodhish,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 3, 2024
@nihal467
Copy link
Member

nihal467 commented Oct 4, 2024

@bodhish

  • fix all the cypress failure

image

  • The page loader is using the old care logo and the new one, so remove the old one

image

  • Re-positon the loader to be present in the middle of the page, as similar as the current staging

note: Behavior can be noticed when we switch between pages using the side-nav, like facility, patient pages

image

  • change the favicon of the care to use the new care logo

image

  • On mobile view, the CARE new icon size is not consistent compared to other icons, so keep the size consistent

image

  • The collapse icon in the mobile responsive view doesn't work when used from the patient consultation page.

image

  • The white padding of the facility page card adjusts dynamically with the page zoom. However, it should consistently extend to the bottom of the page. Currently, at 80% zoom, the padding only reaches about 75% of the page height

@bodhish
Copy link
Member Author

bodhish commented Oct 4, 2024

@nihal467 these are changes you can attempt, give it a try and let me know if you are stuck 🚀

Nice finds 🚀🚀

@nihal467 nihal467 self-assigned this Oct 6, 2024
@bodhish
Copy link
Member Author

bodhish commented Oct 7, 2024

Nice work @nihal467, let me know if you need help, lets get this merged this week

@bodhish
Copy link
Member Author

bodhish commented Oct 8, 2024

@nihal467 can you convert the remaning issues into an issue. lets keep it a large list

@gigincg gigincg merged commit 6e4d06b into develop Oct 8, 2024
26 checks passed
@gigincg gigincg deleted the patient-form-rebuild branch October 8, 2024 04:42
Copy link

github-actions bot commented Oct 8, 2024

@nihal467 @bodhish Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

chakribontha pushed a commit to chakribontha/care_fe that referenced this pull request Oct 9, 2024
Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants