Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second attempt to clean up patient creation form #8706

Merged
merged 36 commits into from
Oct 8, 2024

Conversation

bodhish
Copy link
Member

@bodhish bodhish commented Oct 4, 2024

Continuation from #8680

  • Added schadcn button
  • Cleaned up back button
  • Revamped breadcrumbs
  • Removed external results import in patients page. (Full clean up should be added as a new issue)
  • Use figtree as the default font
image

@bodhish bodhish requested a review from a team as a code owner October 4, 2024 09:19
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 30b436c
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6704c9f3a4790500080ad938
😎 Deploy Preview https://deploy-preview-8706--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Oct 4, 2024

CARE    Run #3554

Run Properties:  status check failed Failed #3554  •  git commit a00af42109: Second attempt to clean up patient creation form
Project CARE
Run status status check failed Failed #3554
Run duration 03m 17s
Commit git commit a00af42109: Second attempt to clean up patient creation form
Committer Bodhish Thomas
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 123

Tests for review

Failed  cypress/e2e/patient_spec/PatientRegistration.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Patient Creation with consultation > Patient Registration using External Result Import Test Replay Screenshots

@bodhish
Copy link
Member Author

bodhish commented Oct 7, 2024

@nihal467 test this out when you get some time, not a priority

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

👋 Hi, @bodhish,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link

cloudflare-workers-and-pages bot commented Oct 8, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 30b436c
Status: ✅  Deploy successful!
Preview URL: https://35dd4985.care-fe.pages.dev
Branch Preview URL: https://patient-form-rebuild-attempt.care-fe.pages.dev

View logs

@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview and removed merge conflict pull requests with merge conflict labels Oct 8, 2024
@bodhish bodhish force-pushed the patient-form-rebuild-attempt-2 branch from f545919 to 475c46f Compare October 8, 2024 05:24
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Oct 8, 2024
@bodhish bodhish merged commit 13a4814 into develop Oct 8, 2024
22 of 25 checks passed
@bodhish bodhish deleted the patient-form-rebuild-attempt-2 branch October 8, 2024 06:03
Copy link

github-actions bot commented Oct 8, 2024

@bodhish Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@bodhish
Copy link
Member Author

bodhish commented Oct 8, 2024

@nihal467 files all the issues in a single issue.

chakribontha pushed a commit to chakribontha/care_fe that referenced this pull request Oct 9, 2024
... also added figtree as default font 

Co-authored-by: Gigin George <mail.gigin@gmail.com>
Co-authored-by: rithviknishad <mail@rithviknishad.dev>
Copy link

sentry-io bot commented Oct 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: undefined is not an object (evaluating 'd[d.length-1].value') transformData(src/Components/Facility/Investiga... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants