Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle/enforce GROUP_NAME_MAX_CHAR on group settings page #2238

Closed
dotmacro opened this issue Jul 20, 2024 · 2 comments · Fixed by #2239
Closed

Properly handle/enforce GROUP_NAME_MAX_CHAR on group settings page #2238

dotmacro opened this issue Jul 20, 2024 · 2 comments · Fixed by #2239
Assignees

Comments

@dotmacro
Copy link
Member

Problem

On the Group Settings page, the text box for the group name has no char limit in the UI. However, there's clearly an enforced limit on the backend because the error message indicates that groupName cannot exceed 50 chars.

groupSettings--groupNameUnlimited--Error

Solution

Fix, presumably by handling GROUP_NAME_MAX_CHAR the same here as during group creation.

@dotmacro
Copy link
Member Author

Additionally, "You can report the error" in the error message is not a link, and not clickable. @taoeffect Should #1945 be reopened, or is this a new issue?

@SebinSong
Copy link
Collaborator

@dotmacro

Additionally, "You can report the error" in the error message is not a link, and not clickable. @taoeffect Should #1945 be reopened, or is this a new issue?

You can see them as separate issues as those are two different UI components. I can handle that bug as part of this task.

taoeffect added a commit that referenced this issue Jul 20, 2024
…imit

#2238 - Char limit UI and validation for group name in GroupSettings.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants