Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2238 - Char limit UI and validation for group name in GroupSettings.vue #2239

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

SebinSong
Copy link
Collaborator

closes #2238

@SebinSong SebinSong self-assigned this Jul 20, 2024
@SebinSong SebinSong changed the title #2238 #2238 - Char limit UI and validation for group name in GroupSettings.vue Jul 20, 2024
@@ -64,7 +72,7 @@ page.c-page

i18n.helper This is the currency that will be displayed for every member of the group, across the platform.

banner-scoped(ref='formMsg' data-test='formMsg')
banner-scoped(ref='formMsg' data-test='formMsg' :allowA='true')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix for unresponsive report the error link.

Copy link

cypress bot commented Jul 20, 2024

Passing run #2755 ↗︎

0 112 10 0 Flakiness 0

Details:

Merge 0eee08c into e89cebe...
Project: group-income Commit: 8bd0f5274c ℹ️
Status: Passed Duration: 10:46 💡
Started: Jul 20, 2024 1:51 AM Ended: Jul 20, 2024 2:02 AM

Review all test suite changes for PR #2239 ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this message!

@taoeffect taoeffect merged commit 4ed1baa into master Jul 20, 2024
4 checks passed
@taoeffect taoeffect deleted the sebin/task/#2238-group-name-limit branch July 20, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly handle/enforce GROUP_NAME_MAX_CHAR on group settings page
2 participants