Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stringMax validation for user display name #2325

Closed
SebinSong opened this issue Sep 2, 2024 · 0 comments · Fixed by #2328
Closed

Implement stringMax validation for user display name #2325

SebinSong opened this issue Sep 2, 2024 · 0 comments · Fixed by #2328
Assignees
@SebinSong
Labels
App:Frontend Kind:Bug Note:UI/UX

Comments

@SebinSong
Copy link
Collaborator

Problem

Apparently there is no stringMax() validation implemented for displayName field in identity contract. Also, it needs n/max indicator UI in UserSettingModal.vue, Just like how it is in the user bio input below.

Solution

Implement them
@SebinSong SebinSong self-assigned this Sep 2, 2024
@SebinSong SebinSong changed the title Implement max-length validation for user 'displayName' in both identity contract and the user-settings modal Implement max-length validation for user 'displayName' in both identity contract and user-settings modal Sep 2, 2024
@SebinSong SebinSong changed the title Implement max-length validation for user 'displayName' in both identity contract and user-settings modal Implement max-length validation for user display name Sep 2, 2024
@SebinSong SebinSong changed the title Implement max-length validation for user display name Implement stringMax validation for user display name Sep 2, 2024
@SebinSong SebinSong mentioned this issue Sep 3, 2024
Merged
taoeffect pushed a commit that referenced this issue Sep 5, 2024
@SebinSong
#2325 - add stringMax() validator for user display name (#2328)
9114ed8 
* add stringMax validator for displayname

* add comment
SebinSong added a commit that referenced this issue Sep 8, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2325-im…
64a0c2d 
…plement-stringmax-for-display-name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Bug Note:UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2325 - add stringMax() validator for user display name okTurtles/group-income
1 participant
@SebinSong