-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2325 - add stringMax()
validator for user display name
#2328
#2325 - add stringMax()
validator for user display name
#2328
Conversation
group-income Run #3012
Run Properties:
|
Project |
group-income
|
Branch Review |
refs/pull/2328/merge
|
Run status |
Passed #3012
|
Run duration | 10m 44s |
Commit |
a6bc9f9c2e ℹ️: Merge 2a1c9855f39b2888b07b867846d27b55397bf9ed into 1d951cdb8065f8ef87ff6ea89767...
|
Committer | Sebin Song |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
10
|
Skipped |
0
|
Passing |
111
|
View all changes introduced in this branch ↗︎ |
Is this a good idea (or at least the 80 characters limit)? While I agree it's usually excessive, there are many cases where someone's full name can be pretty long (e.g., Pablo Picasso, Hubert Blaine Wolfeschlegelsteinhausenbergerdorff (yes, that's the 'short' version)). Another example: Karl-Theodor zu Guttenberg (the current German politician). However, whether someone would use their very long full name as a display name, I'm not sure. |
That's 26 characters
64 characters. So yeah... I think 80 is sufficient. 😄 |
@corrideat Its my perception that people with long name usually want to use a shorter version when possible and also often encourage others to do so too.(Who would enjoy typing 80 characters each time they call someone in the chat?) |
Karl-Theodor Maria Nikolaus Johann Jacob Philipp Franz Joseph Sylvester Buhl-Freiherr von und zu Guttenberg
Pablo Diego José Francisco de Paula Juan Nepomuceno Cipriano de la Santísima Trinidad Ruiz Picasso
This one is over half a KiB
Probably that's what most prefer, yes. But since 80 characters aren't going to fit on screen / the UI component anyhow, it seems like an arbitrary limit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes #2325