Implement pinned messages #2011
Conversation
There was a problem hiding this comment.
Nice work @Silver-IT!
Preliminary review (round 1) done!
In addition to the comments I posted, I found some other issues while testing:
1. Missing "Unpin message" from menu item
As there is a "Pin message" menu item, there should be a corresponding "Unpin message" menu item that appears on pinned messages:
2. Pinned messages don't appear in DMs
The pinned messages menu should appear in DMs as well:
I can't find the unpin icon in FontAwesome. Can I use the same icon(thumbtack) for unpin button? Or this undo icon? PS: I can see that Discord has same icon (thumbtack) for both |
There was a problem hiding this comment.
Nice improvements, this PR is shaping up 👍
I noticed this PR modifies the code for voting on polls and noticed that it introduces some bugs:
For example, above u1 tries to vote on a poll u2 created, and even though they clicked "Submit" the poll doesn't switch to the show the results, and instead remains on the choice screen. That's why in the chat it shows u1 voting multiple times because they just click "Submit" again and again...
Please test all modified code thoroughly, and especially code for which we do not have tests yet.
frontend/views/containers/chatroom/file-attachment/ChatAttachmentPreview.vue
Outdated
Show resolved
Hide resolved
Summary of Changes