Various bugfixes: #2105
Merged
Various bugfixes: #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
corrideat
commented
Jun 21, 2024
•
corrideat
commented
- Comments explaining retain / release logic
- Closes TypeError in internals related to OP_KEYSHARE #2093
- Testing site broken (private chatroom not syncing across devices) #2066 (potential fix)
Passing run #2452 ↗︎
Details:
Review all test suite changes for PR #2105 ↗︎ |
|||||||||||||||
taoeffect
reviewed
Jun 21, 2024
Comment on lines
-1771
to
-1787
| encryptionKeyId, | ||
| ...actorID === memberID && { | ||
| hooks: { | ||
| postpublish: () => { | ||
| sbp('chelonia/contract/retain', chatRoomID) | ||
| } | ||
| } | ||
| } | ||
| encryptionKeyId | ||
| }).catch(e => { | ||
| if (e.name === 'GIErrorUIRuntimeError' && e.cause?.name === 'GIChatroomAlreadyMemberError') { | ||
| if (actorID === memberID) { | ||
| // Increase reference count if we've already joined | ||
| // Note: this addresses syncing the contract from a new device, | ||
| // where `retain` in postpublish hasn't been called and the | ||
| // reference count is zero due to the state being fresh. | ||
| sbp('chelonia/contract/retain', chatRoomID) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.