Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates integration tests for new openapi #146

Closed
wants to merge 4 commits into from

Conversation

swiftone
Copy link
Contributor

@swiftone swiftone commented May 8, 2020

No description provided.

@robertjd
Copy link
Contributor

robertjd commented May 11, 2020

@swiftone I'm not sure why the license headers are being removed from existing files, but they should remain. EDIT: let's talk about this, we may have made a chance in the approach that I'm forgetting about.

const collection = await createdUser.listFactors();
const factors = [];
await collection.each(factor => factors.push(factor));
expect(factors[1]).to.be.instanceof(models.SmsFactor);
expect(factors[0]).to.be.instanceof(models.SecurityQuestionFactor);
console.warn({factors});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console statements

@swiftone
Copy link
Contributor Author

Closing in favor of #147

@swiftone swiftone closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants